-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge oss master #271
merge oss master #271
Conversation
…ess (datahub-project#8615) Co-authored-by: Harshal Sheth <[email protected]>
…t indexed on entity documents (datahub-project#8650)
…b-project#8495) Co-authored-by: Andrew Sikowitz <[email protected]>
) Co-authored-by: John Joyce <[email protected]>
…#8611) Co-authored-by: Indy Prentice <[email protected]>
…sqlglot_lineage performance optimizations (datahub-project#8494) Co-authored-by: Harshal Sheth <[email protected]> Co-authored-by: Tamas Nemeth <[email protected]>
platforms: linux/amd64,linux/arm64/v8 | ||
- name: Compute DataHub Ingestion (Base) Tag | ||
id: tag | ||
run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.tag || 'head' }}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:113: Double quote to prevent globbing and word splitting [shellcheck]
platforms: linux/amd64,linux/arm64/v8 | ||
- name: Compute DataHub Ingestion (Base-Slim) Tag | ||
id: tag | ||
run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.unique_slim_tag || 'head' }}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:125: Double quote to prevent globbing and word splitting [shellcheck]
platforms: linux/amd64,linux/arm64/v8 | ||
- name: Compute DataHub Ingestion (Base-Full) Tag | ||
id: tag | ||
run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.unique_full_tag || 'head' }}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:125: Double quote to prevent globbing and word splitting [shellcheck]
platforms: linux/amd64,linux/arm64/v8 | ||
- name: Compute Tag | ||
id: tag | ||
run: echo "tag=${{ (steps.filter.outputs.datahub-ingestion-base == 'true' || steps.filter.outputs.datahub-ingestion == 'true') && needs.setup.outputs.unique_slim_tag || 'head' }}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:179: Double quote to prevent globbing and word splitting [shellcheck]
platforms: linux/amd64,linux/arm64/v8 | ||
- name: Compute Tag (Full) | ||
id: tag | ||
run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.unique_full_tag || 'head' }}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:125: Double quote to prevent globbing and word splitting [shellcheck]
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #271 +/- ##
==========================================
- Coverage 74.61% 74.08% -0.54%
==========================================
Files 394 398 +4
Lines 40694 41191 +497
==========================================
+ Hits 30364 30515 +151
- Misses 10330 10676 +346
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Conflict resolution done in
@hsheth2 or @RyanHolstien need to review this part is correct or not
plus the image names at the top which have caused issues on quickstart in the past.
Checklist