Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge oss master #271

Merged
merged 55 commits into from
Aug 29, 2023
Merged

merge oss master #271

merged 55 commits into from
Aug 29, 2023

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Aug 25, 2023

Conflict resolution done in

   .github/workflows/docker-unified.yml

@hsheth2 or @RyanHolstien need to review this part is correct or not

      - name: Check whether publishing enabled
        id: publish
        env:
          ENABLE_PUBLISH: ${{ secrets.ORG_DOCKER_PASSWORD != '' && secrets.ACRYL_DOCKER_PASSWORD != '' }}
        run: |
          echo "Enable publish: ${{ env.ENABLE_PUBLISH }}"
          echo "publish=${{ env.ENABLE_PUBLISH }}" >> $GITHUB_OUTPUT

plus the image names at the top which have caused issues on quickstart in the past.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

skrydal and others added 30 commits August 16, 2023 10:32
hsheth2 and others added 18 commits August 23, 2023 22:05
…sqlglot_lineage performance optimizations (datahub-project#8494)

Co-authored-by: Harshal Sheth <[email protected]>
Co-authored-by: Tamas Nemeth <[email protected]>
platforms: linux/amd64,linux/arm64/v8
- name: Compute DataHub Ingestion (Base) Tag
id: tag
run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.tag || 'head' }}" >> $GITHUB_OUTPUT

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:113: Double quote to prevent globbing and word splitting [shellcheck]

platforms: linux/amd64,linux/arm64/v8
- name: Compute DataHub Ingestion (Base-Slim) Tag
id: tag
run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.unique_slim_tag || 'head' }}" >> $GITHUB_OUTPUT

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:125: Double quote to prevent globbing and word splitting [shellcheck]

platforms: linux/amd64,linux/arm64/v8
- name: Compute DataHub Ingestion (Base-Full) Tag
id: tag
run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.unique_full_tag || 'head' }}" >> $GITHUB_OUTPUT

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:125: Double quote to prevent globbing and word splitting [shellcheck]

platforms: linux/amd64,linux/arm64/v8
- name: Compute Tag
id: tag
run: echo "tag=${{ (steps.filter.outputs.datahub-ingestion-base == 'true' || steps.filter.outputs.datahub-ingestion == 'true') && needs.setup.outputs.unique_slim_tag || 'head' }}" >> $GITHUB_OUTPUT

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:179: Double quote to prevent globbing and word splitting [shellcheck]

platforms: linux/amd64,linux/arm64/v8
- name: Compute Tag (Full)
id: tag
run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.unique_full_tag || 'head' }}" >> $GITHUB_OUTPUT

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:125: Double quote to prevent globbing and word splitting [shellcheck]

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 68.40% and project coverage change: -0.54% ⚠️

Comparison is base (5cd220c) 74.61% compared to head (4646c47) 74.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
- Coverage   74.61%   74.08%   -0.54%     
==========================================
  Files         394      398       +4     
  Lines       40694    41191     +497     
==========================================
+ Hits        30364    30515     +151     
- Misses      10330    10676     +346     
Flag Coverage Δ
pytest-testIntegration 50.17% <58.46%> (-0.44%) ⬇️
pytest-testIntegrationBatch1 35.44% <11.90%> (-0.42%) ⬇️
pytest-testQuick 63.33% <26.47%> (-0.85%) ⬇️
pytest-testSlowIntegration 32.43% <9.44%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
metadata-ingestion/src/datahub/cli/docker_cli.py 25.31% <0.00%> (-0.07%) ⬇️
...gestion/src/datahub/emitter/sql_parsing_builder.py 0.00% <0.00%> (ø)
...rc/datahub/ingestion/extractor/json_schema_util.py 89.23% <ø> (ø)
...tion/src/datahub/ingestion/source/dbt/dbt_cloud.py 0.00% <0.00%> (ø)
...n/source/powerbi/dataplatform_instance_resolver.py 100.00% <ø> (+3.84%) ⬆️
...hub/ingestion/source/snowflake/snowflake_schema.py 84.27% <ø> (ø)
...b/ingestion/source/snowflake/snowflake_usage_v2.py 74.05% <ø> (ø)
...estion/src/datahub/ingestion/source/sql_queries.py 0.00% <0.00%> (ø)
...estion/src/datahub/ingestion/source/unity/usage.py 49.61% <0.00%> (ø)
...ta-ingestion/src/datahub/ingestion/graph/client.py 32.10% <16.00%> (-1.23%) ⬇️
... and 27 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asikowitz asikowitz merged commit f5995a2 into master Aug 29, 2023
60 of 65 checks passed
@asikowitz asikowitz deleted the aseem-merge-oss-master branch August 29, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.